Bug 220347 – Stop using MediaRecorder in API test WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sihui Liu]

...

[Sihui Liu]

Created attachment 417057 [details]
Patch

[youenn fablet]

Comment on attachment 417057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417057&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:130
> +    for (_WKExperimentalFeature *feature in [WKPreferences _experimentalFeatures]) {

It might be best to not use media recorder or to make the test work in both cases (MediaRecorder on or off).
WTR can use MediaRecorder with a mock backend in all platforms but the real backend is only supported for recent MacOS versions.

[Sihui Liu]

Created attachment 417100 [details]
Patch

[Sihui Liu]

(In reply to youenn fablet from comment #2)
> Comment on attachment 417057 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417057&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:130
> > +    for (_WKExperimentalFeature *feature in [WKPreferences _experimentalFeatures]) {
> 
> It might be best to not use media recorder or to make the test work in both
> cases (MediaRecorder on or off).
> WTR can use MediaRecorder with a mock backend in all platforms but the real
> backend is only supported for recent MacOS versions.

Removed media recorder and use audio element instead.

[Sihui Liu]

*** Bug 220425 has been marked as a duplicate of this bug. ***

[youenn fablet]

Comment on attachment 417100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417100&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:34
> +#import <WebKit/_WKExperimentalFeature.h>

No longer needed.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/speechrecognition-basic.html:32
> +        };

I would simplify this and just do:
audio.play();
It might be best also to add the audio element to the DOM.
Maybe just add something like:
<audio id="audio" autoplay></audio>
And then write audio.play() here.

[Sihui Liu]

Created attachment 417273 [details]
Patch for landing

[Sihui Liu]

Created attachment 417274 [details]
Patch for landing

[EWS]

Found 1 new test failure: media/controls/showControlsButton.html

[EWS]

Committed r271311: <https://trac.webkit.org/changeset/271311>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417274 [details].

[Radar WebKit Bug Importer]

<rdar://problem/72938893>