Bug 220339

Summary: [JSC] DFG/FTL DirectCall need to respect Wasm IC
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: REOPENED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 221051    
Bug Blocks:    
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2021-01-05 14:19:13 PST
...
Attachments
Patch (9.75 KB, patch)
2021-01-05 16:14 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-01-05 16:14:25 PST
Created attachment 417047 [details] Patch
Yusuke Suzuki
Comment 2 2021-01-05 17:59:25 PST
SamplingProfiler tests' rebaseline were necessary (because of how Wasm IC is called is changed in several places). Done.
Yusuke Suzuki
Comment 3 2021-01-05 18:01:29 PST
** The following JSC stress test failures have been introduced: stress/sampling-profiler-wasm-name-section.js.default stress/sampling-profiler-wasm.js.default wasm.yaml/wasm/function-tests/nameSection.js.default-wasm wasm.yaml/wasm/function-tests/nameSection.js.wasm-air wasm.yaml/wasm/function-tests/nameSection.js.wasm-b3 wasm.yaml/wasm/function-tests/nameSection.js.wasm-collect-continuously wasm.yaml/wasm/function-tests/nameSection.js.wasm-eager wasm.yaml/wasm/function-tests/nameSection.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/nameSection.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/nameSection.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/nameSection.js.wasm-slow-memory Ensured they are working by adjusting test side (since sampling profiler stack is changed).
Yusuke Suzuki
Comment 4 2021-01-05 19:04:14 PST
Committed r271186: <https://trac.webkit.org/changeset/271186>
Radar WebKit Bug Importer
Comment 5 2021-01-05 19:05:32 PST
<rdar://problem/72838323>
WebKit Commit Bot
Comment 6 2021-01-27 11:18:38 PST
Re-opened since this is blocked by bug 221051
Note You need to log in before you can comment on or make changes to this bug.