Bug 220315
| Summary: | build-webkit compilation error on macOS Catalina 10.15.7 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dario D'Amico <dario.damico> |
| Component: | ANGLE | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, dino, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | macOS 10.15 | ||
Dario D'Amico
WebKit does not build on macOS Catalina 10.15.7 because of a compilation error in the Metal Angle renderer.
/Users/dari8942/Desktop/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm:530:17: error:
'setPreserveInvariance:' is only available on macOS 11.0 or newer
[-Werror,-Wunguarded-availability-new]
options.preserveInvariance = true;
^~~~~~~~~~~~~~~~~~
User ap on the Slack WebKit channel suggested to change MAX_ALLOWED to MIN_REQUIRED in the preprocessor conditions that guard the compilation of that line.
It seems like that does the trick because I tried in my local repo and it gets rid of the error; however the build still fails for some other reason that I am investigating.
In short, there seems to be a similar 10.15 vs 11.0 problem that affects Cocoa/AVAssetWriterSPI.h. Not sure whether I should create a separate bug report or just keep adding to this as I discover new compilation errors.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
It's OK to fix all of these at once as long as it's all just version checks and ifdefs, and no deep changes that would require expert review.
Radar WebKit Bug Importer
<rdar://problem/73033480>