| Summary: | [selectors] Update tests from WPT | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||||||||||||||
| Component: | Tools / Tests | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | clopez, ews-watchlist, svillar, webkit-bug-importer, youennf | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=220578 | ||||||||||||||||||||||
| Bug Depends on: | 220243 | ||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Manuel Rego Casasnovas
2021-01-05 02:03:24 PST
Created attachment 416981 [details]
Patch
Created attachment 417153 [details]
Patch
Created attachment 417156 [details]
Patch
Created attachment 417171 [details]
Patch
Created attachment 417256 [details]
Patch
Created attachment 417366 [details]
Patch
Created attachment 417370 [details]
Patch
Created attachment 417375 [details]
Patch
Created attachment 417436 [details]
Patch
Comment on attachment 417436 [details]
Patch
EWSs are green now.
Some tests are skipped as they timeout in Apple platforms, I'll investigate them and look for a solution. But so far we can update the test suite IMHO.
Comment on attachment 417436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review > LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log:12 > +appearance Not sure what this is about... > LayoutTests/platform/glib/TestExpectations:199 > +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ] Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here? Comment on attachment 417436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review Thanks for the review. >> LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log:12 >> +appearance > > Not sure what this is about... This is added automatically by the importer. One of the tests use "apperance" property, which in WebKit is only supported as "-webkit-apperance". So the script renames the property and note down it here. >> LayoutTests/platform/glib/TestExpectations:199 >> +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ] > > Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here? Is there a single file to skip them for both Mac and iOS? Or I'd need to skip them in both files? Comment on attachment 417436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review >>> LayoutTests/platform/glib/TestExpectations:199 >>> +webkit.org/b/185859 imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ] >> >> Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here? > > Is there a single file to skip them for both Mac and iOS? Or I'd need to skip them in both files? After talking with Sergio off-line, he's fine with landing this as is so far, as more work related to these tests is going to be done when implementing :focus-visible. Committed r271395: <https://trac.webkit.org/changeset/271395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417436 [details]. |