Bug 220252

Summary:

[LFC][IFC][Quirk] Let's adopt a less quirky behavior for line breaks on non-empty lines

Product:

WebKit

Reporter:

alan baradlay <zalan>

Component:

Layout and Rendering

Assignee:

alan baradlay <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

alan baradlay

Reported 2021-01-04 12:46:47 PST

<br> in non-standard mode stretches the line box only when the line is empty. e.g. <div><span><br></span></div> will stretch but <div>this will not stretch to 200px<span style="font-size: 200px;"><br></span></div> However it's way too quirky and it does not even match Chrome's behavior.

Attachments
Patch (3.74 KB, patch) 2021-01-04 12:52 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (4.23 KB, patch) 2021-01-10 19:59 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (8.77 KB, patch) 2021-01-11 16:45 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (9.38 KB, patch) 2021-01-12 12:57 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (9.39 KB, patch) 2021-01-12 13:02 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (9.54 KB, patch) 2021-01-12 21:20 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (9.17 KB, patch) 2021-01-13 20:41 PST, alan baradlay	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

alan baradlay

Comment 1 2021-01-04 12:52:51 PST

Created attachment 416960 [details] Patch

alan baradlay

Comment 2 2021-01-10 19:59:26 PST

Created attachment 417359 [details] Patch

Antti Koivisto

Comment 3 2021-01-10 22:27:08 PST

Comment on attachment 417359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417359&action=review > Source/WebCore/ChangeLog:17 > + Removing this quirk makes the inlineLevelBoxAffectsLineBox logic simpler since we don't have to check against > + whether the line is considered empty and the result is aligned with Chrome's behavior. Should it be removed from legacy too?

alan baradlay

Comment 4 2021-01-11 10:08:20 PST

(In reply to Antti Koivisto from comment #3) > Comment on attachment 417359 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417359&action=review > > > Source/WebCore/ChangeLog:17 > > + Removing this quirk makes the inlineLevelBoxAffectsLineBox logic simpler since we don't have to check against > > + whether the line is considered empty and the result is aligned with Chrome's behavior. > > Should it be removed from legacy too? Yeah good point.

Radar WebKit Bug Importer

Comment 5 2021-01-11 12:47:12 PST

<rdar://problem/73009786>

alan baradlay

Comment 6 2021-01-11 16:45:09 PST

Created attachment 417421 [details] Patch

alan baradlay

Comment 7 2021-01-12 12:57:12 PST

Created attachment 417482 [details] Patch

alan baradlay

Comment 8 2021-01-12 13:02:43 PST

Created attachment 417484 [details] Patch