| Summary: | [JSC] Remove unnecessary mov bytecodes when performing simple object pattern destructuring to variables | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 220204 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Yusuke Suzuki
2021-01-01 04:08:03 PST
Created attachment 416879 [details]
Patch
Created attachment 416880 [details]
Patch
Created attachment 416884 [details]
Patch
Created attachment 416885 [details]
Patch
Comment on attachment 416885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416885&action=review r=me, great change! > JSTests/stress/object-pattern-simple-fast-path.js:102 > +}()); Would it be reasonable to add more tests for guards in writableDirectBindingIfPossible()? Like `var`, global object property that is non-writable or accessor, WithStatement? Comment on attachment 416885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416885&action=review >> JSTests/stress/object-pattern-simple-fast-path.js:102 >> +}()); > > Would it be reasonable to add more tests for guards in writableDirectBindingIfPossible()? Like `var`, global object property that is non-writable or accessor, WithStatement? Nice! Added. Committed r271121: <https://trac.webkit.org/changeset/271121> |