Bug 220219

Summary: [JSC] Remove unnecessary mov bytecodes when performing simple object pattern destructuring to variables
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220204    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ashvayka: review+

Yusuke Suzuki
Reported 2021-01-01 04:08:03 PST
[JSC] Remove unnecessary mov bytecodes when performing simple object pattern destructuring to variables
Attachments
Patch (12.14 KB, patch)
2021-01-01 04:13 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.38 KB, patch)
2021-01-01 04:22 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.79 KB, patch)
2021-01-01 13:21 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (13.14 KB, patch)
2021-01-01 13:54 PST, Yusuke Suzuki 		ashvayka: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-01-01 04:13:27 PST
Created attachment 416879 [details] Patch
Yusuke Suzuki
Comment 2 2021-01-01 04:22:16 PST
Created attachment 416880 [details] Patch
Yusuke Suzuki
Comment 3 2021-01-01 13:21:04 PST
Created attachment 416884 [details] Patch
Yusuke Suzuki
Comment 4 2021-01-01 13:54:14 PST
Created attachment 416885 [details] Patch
Alexey Shvayka
Comment 5 2021-01-01 13:56:17 PST
Comment on attachment 416885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416885&action=review r=me, great change! > JSTests/stress/object-pattern-simple-fast-path.js:102 > +}()); Would it be reasonable to add more tests for guards in writableDirectBindingIfPossible()? Like `var`, global object property that is non-writable or accessor, WithStatement?
Yusuke Suzuki
Comment 6 2021-01-02 12:40:25 PST
Comment on attachment 416885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416885&action=review >> JSTests/stress/object-pattern-simple-fast-path.js:102 >> +}()); > > Would it be reasonable to add more tests for guards in writableDirectBindingIfPossible()? Like `var`, global object property that is non-writable or accessor, WithStatement? Nice! Added.
Yusuke Suzuki
Comment 7 2021-01-02 12:46:50 PST
Committed r271121: <https://trac.webkit.org/changeset/271121>
Radar WebKit Bug Importer
Comment 8 2021-01-02 12:47:15 PST
<rdar://problem/72771576>
Note You need to log in before you can comment on or make changes to this bug.