Bug 220135

Summary: [LFC][Integration] Use the pre-computed geometries for the inline level boxes
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2020-12-23 20:40:12 PST
instead of looping through the inline content and computed them all over again.
Attachments
Patch (11.60 KB, patch)
2020-12-23 20:44 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.81 KB, patch)
2020-12-23 21:13 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.68 KB, patch)
2020-12-25 12:15 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-23 20:40:32 PST
<rdar://problem/72642850>
alan
Comment 2 2020-12-23 20:44:16 PST
Created attachment 416736 [details] Patch
alan
Comment 3 2020-12-23 21:13:45 PST
Created attachment 416737 [details] Patch
Antti Koivisto
Comment 4 2020-12-25 08:38:07 PST
Comment on attachment 416737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416737&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70 > + // For integration only. > + void collectInlineContentIfNeeded(); > + void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const ConstraintsForInFlowContent&); Saying that these are "intergration only" is bit misleading since they are used internally in any case. They are just public for integration. Maybe these could stay private and there could be public 'lineLayoutForIntergration' or similar that calls them?
alan
Comment 5 2020-12-25 11:30:57 PST
(In reply to Antti Koivisto from comment #4) > Comment on attachment 416737 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416737&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70 > > + // For integration only. > > + void collectInlineContentIfNeeded(); > > + void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const ConstraintsForInFlowContent&); > > Saying that these are "intergration only" is bit misleading since they are > used internally in any case. They are just public for integration. > > Maybe these could stay private and there could be public > 'lineLayoutForIntergration' or similar that calls them? Yeah, I like that.
alan
Comment 6 2020-12-25 12:15:43 PST
Created attachment 416757 [details] Patch
EWS
Comment 7 2020-12-25 13:46:40 PST
Committed r271085: <https://trac.webkit.org/changeset/271085> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416757 [details].
Note You need to log in before you can comment on or make changes to this bug.