Bug 220099

Summary:

Use an enum class to identify WebGL versions

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, luiz, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kbr: review+, ews-feeder: commit-queue-
EWS test	ews-feeder: commit-queue-
EWS test 2	ews-feeder: commit-queue-
EWS test 3	ews-feeder: commit-queue-
EWS test 4	ews-feeder: commit-queue-
EWS test 5	ews-feeder: commit-queue-
EWS test 6	ews-feeder: commit-queue-

Dean Jackson

Reported 2020-12-22 12:35:34 PST

Use an enum class to identify WebGL versions

Attachments
Patch (14.84 KB, patch) 2020-12-22 12:40 PST, Dean Jackson	kbr: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test (15.62 KB, patch) 2020-12-22 13:25 PST, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test 2 (16.98 KB, patch) 2020-12-22 13:30 PST, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test 3 (18.48 KB, patch) 2020-12-22 13:35 PST, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test 4 (18.83 KB, patch) 2020-12-22 13:43 PST, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test 5 (19.00 KB, patch) 2020-12-22 13:48 PST, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS test 6 (19.10 KB, patch) 2020-12-22 14:03 PST, Dean Jackson	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-12-22 12:36:13 PST

<rdar://problem/72596828>

Dean Jackson

Comment 2 2020-12-22 12:40:11 PST

Created attachment 416681 [details] Patch

Kenneth Russell

Comment 3 2020-12-22 12:44:53 PST

Comment on attachment 416681 [details] Patch Looks good to me. r+

Sam Weinig

Comment 4 2020-12-22 12:48:28 PST

Comment on attachment 416681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416681&action=review r=me Out of interest, why does the platform level GraphicsContext need to know which version of WebGL is being used? > Source/WebCore/html/HTMLCanvasElement.cpp:338 > + return getContextWebGL(HTMLCanvasElement::toWebGLVersion (type)); Looks like you have an extra space here.

Dean Jackson

Comment 5 2020-12-22 13:18:44 PST

Comment on attachment 416681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416681&action=review >> Source/WebCore/html/HTMLCanvasElement.cpp:338 >> + return getContextWebGL(HTMLCanvasElement::toWebGLVersion (type)); > > Looks like you have an extra space here. Fixed.

Dean Jackson

Comment 6 2020-12-22 13:20:02 PST

(In reply to Sam Weinig from comment #4) > Comment on attachment 416681 [details] > Out of interest, why does the platform level GraphicsContext need to know > which version of WebGL is being used? There are a number of places in the GL API that differ between GLES 2 and 3, or rather need to do different things based on the underlying API. I guess this flag should reflect that rather than WebGL versions.

Dean Jackson

Comment 7 2020-12-22 13:25:19 PST

Created attachment 416685 [details] EWS test

Dean Jackson

Comment 8 2020-12-22 13:30:25 PST

Created attachment 416686 [details] EWS test 2

Dean Jackson

Comment 9 2020-12-22 13:35:56 PST

Created attachment 416688 [details] EWS test 3

Dean Jackson

Comment 10 2020-12-22 13:43:43 PST

Created attachment 416690 [details] EWS test 4