Bug 220093

Summary: [WebGL2] deqp/functional/gles3/texturespecification RGB4444 and RGB565 failures on Mac AMD
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, dino, ews-watchlist, graouts, jdarpinian, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch none

Description Kenneth Russell 2020-12-22 10:47:44 PST
Several tests under deqp/functional/gles3/texturespecification/ are failing on macOS with AMD GPUs because of OpenGL driver bugs in the handling of the packed RGB565 and RGBA4444 texture formats. The following tests are failing sub-tests:

  deqp/functional/gles3/texturespecification/
    teximage2d_pbo_2d_00.html
    teximage2d_pbo_2d_01.html
    texsubimage2d_pbo_2d_00.html
    texsubimage2d_pbo_2d_01.html
    texsubimage2d_pbo_cube_01.html

These failures can be worked around by promoting these formats to RGB[A]8.
Comment 1 Kenneth Russell 2020-12-22 10:53:34 PST
Note: related upstream ANGLE bug is http://crbug.com/angleproject/5469 .
Comment 2 Kenneth Russell 2020-12-22 10:53:44 PST
Created attachment 416675 [details]
Patch
Comment 3 EWS Watchlist 2020-12-22 10:54:35 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Alex Christensen 2020-12-22 12:28:13 PST
Comment on attachment 416675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416675&action=review

> Source/ThirdParty/ANGLE/include/platform/FeaturesGL.h:513
> +        "Packed color formats are buggy on Macs with AMD GPUs", &members, "https://anglebug.com/4849"};

Side note:
https://anglebug.com/ is currently using a TLS certificate only valid for *.google.com
I suggest fixing that on your server.
Comment 5 EWS 2020-12-22 12:41:11 PST
Committed r271062: <https://trac.webkit.org/changeset/271062>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416675 [details].
Comment 6 Radar WebKit Bug Importer 2020-12-22 12:42:15 PST
<rdar://problem/72597071>
Comment 7 Kenneth Russell 2020-12-22 15:04:26 PST
(In reply to Alex Christensen from comment #4)
> Comment on attachment 416675 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416675&action=review
> 
> > Source/ThirdParty/ANGLE/include/platform/FeaturesGL.h:513
> > +        "Packed color formats are buggy on Macs with AMD GPUs", &members, "https://anglebug.com/4849"};
> 
> Side note:
> https://anglebug.com/ is currently using a TLS certificate only valid for
> *.google.com
> I suggest fixing that on your server.

Thanks, will work with the ANGLE team to get it fixed.