Bug 220051

Summary: Many websites crash under toDataURL() when enabling GPU process for DOM
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Wenson Hsieh 2020-12-20 18:08:56 PST 
<rdar://problem/72412509>
Comment 1 Wenson Hsieh 2020-12-21 08:14:46 PST 
Created attachment 416603 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-12-21 09:38:11 PST 
Comment on attachment 416603 [details]
Patch

Can some tests be enabled on the bot after this?
Comment 3 Wenson Hsieh 2020-12-21 12:01:59 PST 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 416603 [details]
> Patch
> 
> Can some tests be enabled on the bot after this?

So on closer inspection, it looks like GPU process for DOM is (implicitly) still disabled on the bots, due to the tiled core animation codepath not supporting GPU process (i.e. DrawingArea::supportsGPUProcessRendering), so we never hit this crash :/

I did, however, confirm that the codepaths are exercised by layout tests, so when we do either turn on GPUP for the Mac bots or switch them over to iOS, this patch will allow us to avoid skipping a dozen-or-so crashes that we would otherwise have while running fast/canvas and canvas.
Comment 4 EWS 2020-12-21 12:17:35 PST 
Committed r271036: <https://trac.webkit.org/changeset/271036>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416603 [details].