Bug 220015

Summary: Add test for logical properties in webkit non-standard '-webkit-writing-mode: horizontal-bt' mode
Product: WebKit Reporter: zsun
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, jfernandez, obrufau, rego, simon.fraser, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zsun
Reported 2020-12-18 09:04:10 PST
Add tests to check if logical properties work well in webkit non-standard '-webkit-writing-mode: horizontal-bt' mode
Attachments
Patch (34.89 KB, patch)
2020-12-22 02:20 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (34.89 KB, patch)
2020-12-22 02:28 PST, zsun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2020-12-22 02:20:00 PST
Created attachment 416656 [details] Patch
EWS Watchlist
Comment 2 2020-12-22 02:21:10 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
zsun
Comment 3 2020-12-22 02:28:24 PST
Created attachment 416658 [details] Patch
Manuel Rego Casasnovas
Comment 4 2020-12-22 03:55:35 PST
Comment on attachment 416658 [details] Patch The changes look good, but you need to export them to WPT and merge there first, before merging them here.
Manuel Rego Casasnovas
Comment 5 2020-12-22 04:33:14 PST
Comment on attachment 416658 [details] Patch The WPT has been merged so this is ready to be merged too: https://github.com/web-platform-tests/wpt/pull/26987
EWS
Comment 6 2020-12-22 04:43:03 PST
Committed r271051: <https://trac.webkit.org/changeset/271051> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416658 [details].
Radar WebKit Bug Importer
Comment 7 2020-12-22 04:44:15 PST
<rdar://problem/72583838>
Note You need to log in before you can comment on or make changes to this bug.