Bug 220009

Summary: [WASM-References] Add declared function indexes set to check from what functions we can create refs
Product: WebKit Reporter: Dmitry <dbezhetskov>
Component: WebAssemblyAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: chi187, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Dmitry
Reported 2020-12-18 00:10:57 PST
[WASM-References] Add declared function indexes set to check from what functions we can create refs
Attachments
Patch (12.25 KB, patch)
2020-12-18 00:17 PST, Dmitry 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (12.29 KB, patch)
2020-12-18 00:32 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (13.97 KB, patch)
2020-12-26 20:02 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dmitry
Comment 1 2020-12-18 00:17:50 PST
Created attachment 416501 [details] Patch
Dmitry
Comment 2 2020-12-18 00:32:41 PST
Created attachment 416503 [details] Patch
Sergey Rubanov
Comment 3 2020-12-18 01:18:54 PST
Comment on attachment 416503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416503&action=review > Source/JavaScriptCore/wasm/WasmModuleInformation.h:78 > + void addDeclaredFunction(uint32_t index) { m_declaredFunctions.set(index); } It could be a constant member function too probably?
Yusuke Suzuki
Comment 4 2020-12-18 02:22:54 PST
Comment on attachment 416503 [details] Patch r=me
Radar WebKit Bug Importer
Comment 5 2020-12-25 00:11:14 PST
<rdar://problem/72669430>
Dmitry
Comment 6 2020-12-26 20:02:28 PST
Created attachment 416795 [details] Patch
Dmitry
Comment 7 2020-12-26 20:04:48 PST
Comment on attachment 416503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416503&action=review >> Source/JavaScriptCore/wasm/WasmModuleInformation.h:78 >> + void addDeclaredFunction(uint32_t index) { m_declaredFunctions.set(index); } > > It could be a constant member function too probably? yes, but I don't truly understand why we need to declare this as const? It is a part of ModuleInfo that we change. btw, don't understand why addReferencedFunction is const too, do you know why it is written like that?
Dmitry
Comment 8 2020-12-26 20:04:56 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=416503&action=review >> Source/JavaScriptCore/wasm/WasmModuleInformation.h:78 >> + void addDeclaredFunction(uint32_t index) { m_declaredFunctions.set(index); } > > It could be a constant member function too probably? yes, but I don't truly understand why we need to declare this as const? It is a part of ModuleInfo that we change. btw, don't understand why addReferencedFunction is const too, do you know why it is written like that?
Yusuke Suzuki
Comment 9 2020-12-26 20:37:39 PST
Comment on attachment 416795 [details] Patch r=me if EWS gets green :)
EWS
Comment 10 2020-12-27 15:35:55 PST
Committed r271097: <https://trac.webkit.org/changeset/271097> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416795 [details].
Note You need to log in before you can comment on or make changes to this bug.