Bug 219992

Summary: [webkitscmpy] Correct mock `git log` call in standard git repositories
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219982
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-12-17 12:26:57 PST
Operator precedence makes it so that our mock `git log` command returns an empty log when the mock repository is not a git-svn repository.
Attachments
Patch (5.18 KB, patch)
2020-12-17 12:31 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.18 KB, patch)
2020-12-17 12:53 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.17 KB, patch)
2020-12-17 14:39 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-17 12:27:18 PST
<rdar://problem/72436380>
Jonathan Bedard
Comment 2 2020-12-17 12:31:03 PST
Created attachment 416450 [details] Patch
Jonathan Bedard
Comment 3 2020-12-17 12:53:43 PST
Created attachment 416457 [details] Patch
dewei_zhu
Comment 4 2020-12-17 13:06:23 PST
r=me
Jonathan Bedard
Comment 5 2020-12-17 14:39:14 PST
Created attachment 416471 [details] Patch for landing
EWS
Comment 6 2020-12-17 15:30:45 PST
Committed r270956: <https://trac.webkit.org/changeset/270956> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416471 [details].
Note You need to log in before you can comment on or make changes to this bug.