Bug 219990

Summary:

[WebAudio] Simplify code related to dispatchToRenderThread

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, calvaris, cdumez, eric.carlson, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, philipj, pnormand, ryuan.choi, sergio, vjaquez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

220112

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2020-12-17 12:18:45 PST

Simplify code related to dispatchToRenderThread in WebAudio: 1. AudioDestination::start() now always gets called with a non-null dispatchToRenderThread lambda. In the case where there is no AudioWorkletThread to dispatch to, the lambda simply calls its task synchronously. 2. For Cocoa ports, make it so that only AudioDestinationCocoa needs to worry about the dispatchToRenderThread lambda. The dispatchToRenderThread lambda is no longer exposed to subclasses such as MockAudioDestinationCocoa & RemoteAudioDestinationProxy.

Attachments
Patch (18.91 KB, patch) 2020-12-17 12:42 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (22.01 KB, patch) 2020-12-17 13:02 PST, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (21.95 KB, patch) 2020-12-17 13:05 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (22.51 KB, patch) 2020-12-17 13:11 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (22.81 KB, patch) 2020-12-17 13:16 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.