Bug 219984

Summary: [MotionMark] Increase the warm-up time for each sub-test from 100ms to 1000ms
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ews-watchlist, jbedard, jonlee, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2020-12-17 10:41:25 PST
In macOS Big Sur, the Multiply and the Images sub-tests started to experience bi-modality in their scores especially on newer hardware. This problem is due to a short warmup time. The initial score of a sub-test is crucial in deciding how much the complexity can grow. Because the system may be doing an expensive work only at the beginning of the sub-test (e.g. initializing a cache), drawing a simple object may take much longer than it usually does. MotionMark test harness will be mislead and believe that this drawing operation is always expensive and will not try to increase the complexity of the test much. This complexity is the score of the test. Increasing the warm-up time will allow the system to finish its initialization before the test sampling starts. This should prevent the system initialization work from affecting the sub-test score.
Attachments
Patch (2.55 KB, patch)
2020-12-17 11:04 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-12-17 10:42:42 PST
<rdar://problem/72143661>
Said Abou-Hallawa
Comment 2 2020-12-17 11:04:38 PST
Created attachment 416439 [details] Patch
EWS
Comment 3 2020-12-17 15:44:23 PST
Committed r270959: <https://trac.webkit.org/changeset/270959> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416439 [details].
Note You need to log in before you can comment on or make changes to this bug.