Bug 219962

Summary: [LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2020-12-16 15:04:56 PST
ssia
Attachments
Patch (7.72 KB, patch)
2020-12-16 15:35 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.50 KB, patch)
2020-12-16 19:49 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.52 KB, patch)
2020-12-16 20:23 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.53 KB, patch)
2020-12-17 10:11 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.02 KB, patch)
2020-12-18 21:27 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-12-16 15:35:49 PST
Created attachment 416366 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-12-16 15:37:43 PST
<rdar://problem/72402622>
alan
Comment 3 2020-12-16 19:49:45 PST
Created attachment 416382 [details] Patch
alan
Comment 4 2020-12-16 20:23:08 PST
Created attachment 416385 [details] Patch
Antti Koivisto
Comment 5 2020-12-16 23:27:08 PST
Comment on attachment 416385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416385&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:345 > -void LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically(LineBox& lineBox) > +void LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically(LineBox& lineBox) The important fix!
alan
Comment 6 2020-12-17 10:11:35 PST
Created attachment 416435 [details] Patch
alan
Comment 7 2020-12-18 21:27:49 PST
Created attachment 416567 [details] Patch
EWS
Comment 8 2020-12-19 05:16:28 PST
Committed r271002: <https://trac.webkit.org/changeset/271002> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416567 [details].
Note You need to log in before you can comment on or make changes to this bug.