Summary: | REGRESSION: Webkit crashes while loading manderleygolf.com | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | nick r <i_nick> | ||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | ap, bdakin, eric, koivisto, mihnea | ||||
Priority: | P1 | Keywords: | InRadar, NeedsReduction, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
URL: | http://manderleygolf.com | ||||||
Attachments: |
|
Description
nick r
2008-10-30 20:33:56 PDT
I can also reproduce this with r37990. I had to reload the page several times for it to happen though. Seems to have reproduced for me the first time on r38278. ASSERTION FAILED: !pendingScripts.isEmpty() (/Users/eseidel/Projects/WebKit/WebCore/html/HTMLTokenizer.cpp:1978 virtual void WebCore::HTMLTokenizer::notifyFinished(WebCore::CachedResource*)) I thought the fix for this was to clear m_hasScriptsWaitingForStylesheets in HTMLTokenizer::reset(), but that doesn't fix the issue. (Although I think the change is still a good one. If we somehow reset the tokenizer we throw away all the pending scripts, thus we no longer can have scripts waiting for stylesheets. :) Created attachment 25097 [details]
Make sure to set m_hasScriptsWaitingForStylesheets to false when clearing m_pendingScripts
WebCore/html/HTMLTokenizer.cpp | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
Comment on attachment 25097 [details]
Make sure to set m_hasScriptsWaitingForStylesheets to false when clearing m_pendingScripts
Test case?
I think it should be possible to create a test case, but I haven't come up with one yet. How is this related to bug 22073? Its fix touches the same code. |