Bug 219869

Summary: Add webkit- prefix to SpeechRecognition
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
WIP
none
Patch
none
Patch for landing none

Sihui Liu
Reported 2020-12-14 12:08:02 PST
...
Attachments
Patch (14.55 KB, patch)
2020-12-14 12:14 PST, Sihui Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (38.73 KB, patch)
2020-12-14 16:19 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
WIP (30.50 KB, patch)
2020-12-14 16:24 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (33.37 KB, patch)
2020-12-14 21:49 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.42 KB, patch)
2020-12-15 14:16 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-12-14 12:14:11 PST
Created attachment 416182 [details] Patch
Sihui Liu
Comment 2 2020-12-14 16:19:59 PST
Created attachment 416205 [details] Patch
Sihui Liu
Comment 3 2020-12-14 16:24:15 PST
Created attachment 416207 [details] WIP
Sihui Liu
Comment 4 2020-12-14 21:49:26 PST
Created attachment 416224 [details] Patch
youenn fablet
Comment 5 2020-12-15 00:26:36 PST
Comment on attachment 416224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416224&action=review > Source/WebCore/Modules/speech/SpeechRecognition.idl:29 > + InterfaceName=webkitSpeechRecognition, I think we might want to have both webkitSpeechRecognition and SpeechRecognition be defined. I would add a separate setting to enable this prefixed version as well, like done for web audio.
Sihui Liu
Comment 6 2020-12-15 12:00:28 PST
(In reply to youenn fablet from comment #5) > Comment on attachment 416224 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416224&action=review > > > Source/WebCore/Modules/speech/SpeechRecognition.idl:29 > > + InterfaceName=webkitSpeechRecognition, > > I think we might want to have both webkitSpeechRecognition and > SpeechRecognition be defined. > I would add a separate setting to enable this prefixed version as well, like > done for web audio. Per discussion on Slack, I guess we are Okay with only prefix version first.
Geoffrey Garen
Comment 7 2020-12-15 13:11:37 PST
Comment on attachment 416224 [details] Patch r=me
EWS
Comment 8 2020-12-15 13:50:07 PST
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Sihui Liu
Comment 9 2020-12-15 14:16:33 PST
Created attachment 416292 [details] Patch for landing
EWS
Comment 10 2020-12-15 15:04:49 PST
Committed r270868: <https://trac.webkit.org/changeset/270868> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416292 [details].
Radar WebKit Bug Importer
Comment 11 2020-12-15 15:05:20 PST
<rdar://problem/72359735>
Note You need to log in before you can comment on or make changes to this bug.