Bug 219865

Summary: [GLIB] Missing header for std::once_flag in WebKitInitialize.cpp
Product: WebKit Reporter: Pablo Saavedra <psaavedra>
Component: WebKitGTKAssignee: Pablo Saavedra <psaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch none

Pablo Saavedra
Reported 2020-12-14 11:29:11 PST
Error: ../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp: In function �~@~Xvoid WebKit::webkitInitialize()�~@~Y: ../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:61:17: error: �~@~Xonce_flag�~@~Y in namespace �~@~Xstd�~@~Y does not name a type 61 | static std::once_flag onceFlag; | ^~~~~~~~~ ../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:32:1: note: �~@~Xstd::once_flag�~@~Y is defined in header �~@~X<mutex>�~@~Y; did you forget to �~@~X#include <mutex>�~@~Y? 31 | #include <wtf/glib/GUniquePtr.h> +++ |+#include <mutex> 32 |
Attachments
patch (1.16 KB, patch)
2020-12-14 11:31 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pablo Saavedra
Comment 1 2020-12-14 11:31:50 PST
Created attachment 416178 [details] patch
EWS Watchlist
Comment 2 2020-12-14 11:32:57 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS
Comment 3 2020-12-14 12:18:38 PST
Committed r270797: <https://trac.webkit.org/changeset/270797> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416178 [details].
Note You need to log in before you can comment on or make changes to this bug.