Summary: | [macOS] Add sandbox parameter for message filter entitlement status | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 219935 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2020-12-14 06:40:01 PST
Created attachment 416153 [details]
Patch
Created attachment 416159 [details]
Patch
Comment on attachment 416159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416159&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:119 > + (if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") Is it not possible to have the conditional just apply to the message filter bit of the code? That might make this easier to understand. (In reply to Brent Fulgham from comment #4) > Comment on attachment 416159 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416159&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:119 > > + (if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") > > Is it not possible to have the conditional just apply to the message filter > bit of the code? That might make this easier to understand. That would be better, but it does not seem to be possible, since the if clause cannot appear inside another clause, it appears. Thanks for reviewing! Comment on attachment 416159 [details]
Patch
Lots of indenting! r=me
Created attachment 416235 [details]
Patch
(In reply to Brent Fulgham from comment #6) > Comment on attachment 416159 [details] > Patch > > Lots of indenting! r=me Fixed in latest patch. Thanks for reviewing! Committed r270829: <https://trac.webkit.org/changeset/270829> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416235 [details]. Re-opened since this is blocked by bug 219935 Created attachment 416321 [details]
Patch
Committed r270887: <https://trac.webkit.org/changeset/270887> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416321 [details]. |