Summary: | [JSC] Introduce vmEntryCustomAccessor and vmEntryHostFunction for JITCage | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-12-13 22:28:00 PST
Created attachment 416137 [details]
Patch
Created attachment 416138 [details]
Patch
Removed assertIsHostFunction
Comment on attachment 416137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416137&action=review > Source/JavaScriptCore/runtime/NativeFunction.h:36 > +using RawNativeFunctionWithPtr = EncodedJSValue(JSC_HOST_CALL_ATTRIBUTES*)(JSGlobalObject*, CallFrame*, void*); Please remove this since it is not used. > Source/JavaScriptCore/runtime/PutPropertySlot.h:42 > - typedef bool (*PutValueFunc)(JSGlobalObject*, EncodedJSValue thisObject, EncodedJSValue value); > + using PutValueFunc = bool (*)(JSGlobalObject*, EncodedJSValue, EncodedJSValue); > + using PutValueFuncWithPtr = bool (*)(JSGlobalObject*, EncodedJSValue, EncodedJSValue, void*); Would you mind keeping the variable names `thisObject` and `value` to document the different purposes of the 2 EncodedJSValue arguments? > Source/WTF/wtf/PlatformCallingConventions.h:96 > +#define JSC_DEFINE_JIT_OPERATION_WITH_ATTRIBUTES_WITHOUT_VARIABLE(functionName, attributes, returnType, parameters) \ > + attributes returnType JIT_OPERATION_ATTRIBUTES functionName parameters Should we get rid of the attributes argument since it is never used? Do you think there's value in keeping it? Comment on attachment 416138 [details]
Patch
r=me
Comment on attachment 416137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416137&action=review Thanks! >> Source/JavaScriptCore/runtime/NativeFunction.h:36 >> +using RawNativeFunctionWithPtr = EncodedJSValue(JSC_HOST_CALL_ATTRIBUTES*)(JSGlobalObject*, CallFrame*, void*); > > Please remove this since it is not used. Removed. >> Source/JavaScriptCore/runtime/PutPropertySlot.h:42 >> + using PutValueFuncWithPtr = bool (*)(JSGlobalObject*, EncodedJSValue, EncodedJSValue, void*); > > Would you mind keeping the variable names `thisObject` and `value` to document the different purposes of the 2 EncodedJSValue arguments? Recovered. >> Source/WTF/wtf/PlatformCallingConventions.h:96 >> + attributes returnType JIT_OPERATION_ATTRIBUTES functionName parameters > > Should we get rid of the attributes argument since it is never used? Do you think there's value in keeping it? Removed. Committed r270764: <https://trac.webkit.org/changeset/270764> Committed r270888: <https://trac.webkit.org/changeset/270888> |