Bug 219820

Summary: Remove WKDownloadDelegate.didWriteData
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: james.savage, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2020-12-11 21:01:11 PST
Remove WKDownloadDelegate.didWriteData
Attachments
Patch (24.08 KB, patch)
2020-12-11 21:03 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (24.14 KB, patch)
2020-12-14 10:15 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-12-11 21:03:00 PST
Created attachment 416086 [details] Patch
James Savage
Comment 2 2020-12-12 13:36:16 PST
Comment on attachment 416086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416086&action=review > Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:221 > + downloadProgress = [NSProgress progressWithTotalUnitCount:-1]; Presumably -1 is a sentinel for undetermined/indeterminate progress? Why was this 100 originally?
Alex Christensen
Comment 3 2020-12-12 14:00:07 PST
It is, and a download that has an unknown content length uses -1. I initially used 100 based on NSURLSession's behavior, but I decided it would be better to consistently use -1 for non-determined length.
EWS
Comment 4 2020-12-12 14:00:47 PST
james.savage@apple.com does not have reviewer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 416086 [details] from commit queue.
Sam Weinig
Comment 5 2020-12-13 08:37:39 PST
Comment on attachment 416086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416086&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:221 >> + downloadProgress = [NSProgress progressWithTotalUnitCount:-1]; > > Presumably -1 is a sentinel for undetermined/indeterminate progress? Why was this 100 originally? Maybe throwing the -1 into a constant will help clear this up.
Alex Christensen
Comment 6 2020-12-14 10:15:50 PST
Created attachment 416169 [details] Patch
EWS
Comment 7 2020-12-14 11:27:58 PST
Committed r270790: <https://trac.webkit.org/changeset/270790> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416169 [details].
Radar WebKit Bug Importer
Comment 8 2020-12-14 11:28:18 PST
<rdar://problem/72306511>
Note You need to log in before you can comment on or make changes to this bug.