Summary: | `navigator.credentials.create()` returns immediately with `NotAllowedError` if credential already registered. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas Garron <lgarron> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | beidson, bfulgham, cdumez, commit-queue, darin, jiewen_tan, pascoe, tim.cappalli, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | Safari 14 | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 231936 | ||||||||||||||||
Bug Blocks: | 181943 | ||||||||||||||||
Attachments: |
|
Description
Lucas Garron
2020-12-11 16:19:16 PST
Created attachment 441440 [details]
Patch
Comment on attachment 441440 [details]
Patch
r=me
Created attachment 441621 [details]
Patch
Committed r284413 (243182@main): <https://commits.webkit.org/243182@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441621 [details]. Re-opened since this is blocked by bug 231936 Reverted in https://trac.webkit.org/changeset/284429/webkit Created attachment 441781 [details]
Patch
Created attachment 441790 [details]
Patch
Comment on attachment 441790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441790&action=review > Source/WebKit/ChangeLog:11 > + A fixme to add this was inadvertently removed in https://bugs.webkit.org/attachment.cgi?id=393180&action=prettypatch nit: extra space before URL > Source/WebKit/ChangeLog:13 > + Reviewed by NOBODY (OOPS!). This is supposed to come *before* the description, not after. Created attachment 441798 [details]
Patch
Comment on attachment 441798 [details]
Patch
r=me (and Chris)
Waiting for iOS-wk2 to finish before adding cq+ Created attachment 441826 [details]
Patch
Committed r284532 (243274@main): <https://commits.webkit.org/243274@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441826 [details]. Comment on attachment 441826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441826&action=review > Source/WebKit/ChangeLog:2 > +2021-10-19 John Pascoe <j_pascoe@apple.com> > + [WebAuthn] Obtain consent to create new credential when platform authenticator in excludedCredentials Trivial formatting mistake: there should be a blank line here. |