Summary: | Introduce RenderLayerScrollableArea | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||||
Component: | Layout and Rendering | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alex, annulen, bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, mjs, pdr, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2020-12-11 16:02:56 PST
Created attachment 416061 [details]
Patch
Created attachment 416067 [details]
Patch
Comment on attachment 416067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416067&action=review > Source/WebCore/rendering/RenderLayerScrollableArea.cpp:19 > + * of either the Mozilla Public License Version 1.1, found at This is a pretty odd license for WebKit, is it intentional? We tend to prefer BSD-2; https://webkit.org/licensing-webkit/ mentions the LGPL, and there is some LGPL code, but not sure about this MPL bit. I would check with someone to make sure this is right! (In reply to Tim Horton from comment #3) > Comment on attachment 416067 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416067&action=review > > > Source/WebCore/rendering/RenderLayerScrollableArea.cpp:19 > > + * of either the Mozilla Public License Version 1.1, found at > > This is a pretty odd license for WebKit, is it intentional? We tend to > prefer BSD-2; https://webkit.org/licensing-webkit/ mentions the LGPL, and > there is some LGPL code, but not sure about this MPL bit. I would check with > someone to make sure this is right! I copy & pasted the license from RenderLayer, since RenderLayerScrollableArea will contain moved code from RenderLayer mostly, with slight adaptions (s/this/m_layer/). I assumed that I would need to preserve the original license, no? I'm not an expert on this topic, please enlighten me if that's incorrect. (In reply to Nikolas Zimmermann from comment #4) > (In reply to Tim Horton from comment #3) > > Comment on attachment 416067 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=416067&action=review > > > > > Source/WebCore/rendering/RenderLayerScrollableArea.cpp:19 > > > + * of either the Mozilla Public License Version 1.1, found at > > > > This is a pretty odd license for WebKit, is it intentional? We tend to > > prefer BSD-2; https://webkit.org/licensing-webkit/ mentions the LGPL, and > > there is some LGPL code, but not sure about this MPL bit. I would check with > > someone to make sure this is right! > > I copy & pasted the license from RenderLayer, since > RenderLayerScrollableArea will contain moved code from RenderLayer mostly, > with slight adaptions (s/this/m_layer/). > > I assumed that I would need to preserve the original license, no? > I'm not an expert on this topic, please enlighten me if that's incorrect. Ah! In that case I think you probably want to pull the full copyright header along too. (In reply to Tim Horton from comment #5) > Ah! In that case I think you probably want to pull the full copyright header > along too. Fair enough, will include that in the next variant -- this doesn't build with clang atm anyhow :-) Created attachment 416108 [details]
Patch
Comment on attachment 416108 [details] Patch Clearing flags on attachment: 416108 Committed r271111: <https://trac.webkit.org/changeset/271111> All reviewed patches have been landed. Closing bug. |