Summary: | Expose SPI for enabling/disabling Private Click Measurement | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, sam, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brent Fulgham
2020-12-11 10:42:03 PST
Created attachment 416018 [details]
Patch
Comment on attachment 416018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416018&action=review > Source/WebKit/UIProcess/API/C/WKPreferencesRef.h:356 > +WK_EXPORT bool WKPreferencesGetPrivateClickMeasurementEnabled(WKPreferencesRef preferencesRef); Let's not add more C API unless we really need it. Created attachment 416042 [details]
Patch for landing
Committed r270710: <https://trac.webkit.org/changeset/270710> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416042 [details]. Comment on attachment 416042 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=416042&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:3791 > + settings.setPrivateClickMeasurementEnabled(store.getBoolValueForKey(WebPreferencesKey::privateClickMeasurementEnabledKey())); This line is not necessary and is duplicating work done by the generated preferences code. |