| Summary: | Make MixedContentChecker stateless | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
| Component: | Page Loading | Assignee: | Rob Buis <rbuis> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, mifenton, toyoshim, webkit-bug-importer, yutak | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Buis
2020-12-11 01:25:41 PST
Created attachment 415978 [details]
Patch
Created attachment 416120 [details]
Patch
Comment on attachment 416120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416120&action=review > Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp:413 > if (document.frame()) { if (auto* frame = document.frame()) > Source/WebCore/loader/DocumentThreadableLoader.cpp:593 > if (m_document.frame()) { if (auto* frame = m_document.frame()) > Source/WebCore/loader/MixedContentChecker.cpp:59 > + frame.document()->addConsoleMessage(MessageSource::Security, MessageLevel::Warning, message); Let's null check the document just because we can. > Source/WebCore/loader/MixedContentChecker.h:-69 > - Frame& m_frame; Nice. Created attachment 416401 [details]
Patch
Committed r270931: <https://trac.webkit.org/changeset/270931> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416401 [details]. |