Bug 219771

Summary: Make MixedContentChecker stateless
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Page LoadingAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, mifenton, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-12-11 01:25:41 PST
Make MixedContentChecker stateless.
Attachments
Patch (23.34 KB, patch)
2020-12-11 01:27 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (23.52 KB, patch)
2020-12-13 09:07 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (23.66 KB, patch)
2020-12-17 00:38 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-12-11 01:27:21 PST
Created attachment 415978 [details] Patch
Rob Buis
Comment 2 2020-12-13 09:07:56 PST
Created attachment 416120 [details] Patch
Alex Christensen
Comment 3 2020-12-16 12:47:44 PST
Comment on attachment 416120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416120&action=review > Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp:413 > if (document.frame()) { if (auto* frame = document.frame()) > Source/WebCore/loader/DocumentThreadableLoader.cpp:593 > if (m_document.frame()) { if (auto* frame = m_document.frame()) > Source/WebCore/loader/MixedContentChecker.cpp:59 > + frame.document()->addConsoleMessage(MessageSource::Security, MessageLevel::Warning, message); Let's null check the document just because we can. > Source/WebCore/loader/MixedContentChecker.h:-69 > - Frame& m_frame; Nice.
Rob Buis
Comment 4 2020-12-17 00:38:07 PST
Created attachment 416401 [details] Patch
EWS
Comment 5 2020-12-17 03:14:23 PST
Committed r270931: <https://trac.webkit.org/changeset/270931> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416401 [details].
Radar WebKit Bug Importer
Comment 6 2020-12-17 03:15:45 PST
<rdar://problem/72420479>
Note You need to log in before you can comment on or make changes to this bug.