Bug 219738

Summary: [macOS] Remove Mobile Asset access from the WebContent process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2020-12-10 05:27:19 PST 
Remove Mobile Asset access from the WebContent process on macOS, since there are no reports of this being used.
Comment 1 Per Arne Vollan 2020-12-10 05:27:45 PST 
<rdar://problem/60650074>
Comment 2 Per Arne Vollan 2020-12-10 05:33:53 PST 
Created attachment 415861 [details]
Patch
Comment 3 Brent Fulgham 2020-12-10 10:40:20 PST 
Comment on attachment 415861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415861&action=review

Just remove the "with telemetry" rule,

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:961
> +    (with report) (with telemetry)

Telemetry doesn't exist pre-110000
Comment 4 Per Arne Vollan 2020-12-10 11:17:19 PST 
Created attachment 415905 [details]
Patch
Comment 5 Per Arne Vollan 2020-12-10 11:18:00 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 415861 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415861&action=review
> 
> Just remove the "with telemetry" rule,
> 

Fixed.

> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:961
> > +    (with report) (with telemetry)
> 
> Telemetry doesn't exist pre-110000

Thanks for reviewing!
Comment 6 Brent Fulgham 2020-12-11 11:04:03 PST 
Comment on attachment 415905 [details]
Patch

r=me
Comment 7 Per Arne Vollan 2020-12-11 11:06:15 PST 
Comment on attachment 415905 [details]
Patch

Thanks for reviewing!
Comment 8 EWS 2020-12-11 11:27:07 PST 
Committed r270691: <https://trac.webkit.org/changeset/270691>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415905 [details].