Bug 219733

Summary: [iOS] Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2020-12-10 00:42:16 PST
Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU.
Comment 1 Per Arne Vollan 2020-12-10 00:42:38 PST
<rdar://problem/70628137>
Comment 2 Per Arne Vollan 2020-12-10 00:49:28 PST
Created attachment 415844 [details]
Patch
Comment 3 Brent Fulgham 2020-12-10 09:23:16 PST
Comment on attachment 415844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415844&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU.

Probably worth adding a comment:

"The IOGPU class is the superclass of AGXDeviceUserClient, and is the preferred IOKit reference to use according to the Sandbox team."
Comment 4 Per Arne Vollan 2020-12-11 02:46:13 PST
Created attachment 415983 [details]
Patch
Comment 5 Per Arne Vollan 2020-12-11 02:47:34 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 415844 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415844&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU.
> 
> Probably worth adding a comment:
> 
> "The IOGPU class is the superclass of AGXDeviceUserClient, and is the
> preferred IOKit reference to use according to the Sandbox team."

Fixed.

Thanks for reviewing!
Comment 6 EWS 2020-12-11 03:40:19 PST
Committed r270674: <https://trac.webkit.org/changeset/270674>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415983 [details].
Comment 7 Wenson Hsieh 2020-12-12 12:50:04 PST
Reverted r270674 for reason:

Broke web content rendering on iOS

Committed r270739: <https://trac.webkit.org/changeset/270739>
Comment 8 Per Arne Vollan 2021-02-17 07:04:03 PST
Created attachment 420640 [details]
Patch
Comment 9 Brent Fulgham 2021-02-17 09:38:31 PST
Comment on attachment 420640 [details]
Patch

r=me. We should remember to have a final clean-up radar to remove the dynamic extensions when the GPU Process is fully active and always on.
Comment 10 Per Arne Vollan 2021-02-17 15:06:40 PST
Comment on attachment 420640 [details]
Patch

Thanks for reviewing!
Comment 11 EWS 2021-02-17 15:14:45 PST
Committed r273036: <https://commits.webkit.org/r273036>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420640 [details].