Summary: | [iOS] Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Per Arne Vollan
2020-12-10 00:42:16 PST
Created attachment 415844 [details]
Patch
Comment on attachment 415844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415844&action=review r=me > Source/WebKit/ChangeLog:9 > + Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU. Probably worth adding a comment: "The IOGPU class is the superclass of AGXDeviceUserClient, and is the preferred IOKit reference to use according to the Sandbox team." Created attachment 415983 [details]
Patch
(In reply to Brent Fulgham from comment #3) > Comment on attachment 415844 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415844&action=review > > r=me > > > Source/WebKit/ChangeLog:9 > > + Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU. > > Probably worth adding a comment: > > "The IOGPU class is the superclass of AGXDeviceUserClient, and is the > preferred IOKit reference to use according to the Sandbox team." Fixed. Thanks for reviewing! Committed r270674: <https://trac.webkit.org/changeset/270674> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415983 [details]. Reverted r270674 for reason: Broke web content rendering on iOS Committed r270739: <https://trac.webkit.org/changeset/270739> Created attachment 420640 [details]
Patch
Comment on attachment 420640 [details]
Patch
r=me. We should remember to have a final clean-up radar to remove the dynamic extensions when the GPU Process is fully active and always on.
Comment on attachment 420640 [details]
Patch
Thanks for reviewing!
Committed r273036: <https://commits.webkit.org/r273036> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420640 [details]. |