Bug 219733

Summary:

[iOS] Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2020-12-10 00:42:16 PST

Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU.

Attachments
Patch (3.15 KB, patch) 2020-12-10 00:49 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (3.29 KB, patch) 2020-12-11 02:46 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (1.60 KB, patch) 2021-02-17 07:04 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2020-12-10 00:42:38 PST

<rdar://problem/70628137>

Per Arne Vollan

Comment 2 2020-12-10 00:49:28 PST

Created attachment 415844 [details] Patch

Brent Fulgham

Comment 3 2020-12-10 09:23:16 PST

Comment on attachment 415844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415844&action=review r=me > Source/WebKit/ChangeLog:9 > + Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU. Probably worth adding a comment: "The IOGPU class is the superclass of AGXDeviceUserClient, and is the preferred IOKit reference to use according to the Sandbox team."

Per Arne Vollan

Comment 4 2020-12-11 02:46:13 PST

Created attachment 415983 [details] Patch

Per Arne Vollan

Comment 5 2020-12-11 02:47:34 PST

(In reply to Brent Fulgham from comment #3) > Comment on attachment 415844 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415844&action=review > > r=me > > > Source/WebKit/ChangeLog:9 > > + Remove access to the IOKIt class AGXDeviceUserClient in the WebContent process on iOS, since this is not needed when allowing access to IOGPU. > > Probably worth adding a comment: > > "The IOGPU class is the superclass of AGXDeviceUserClient, and is the > preferred IOKit reference to use according to the Sandbox team." Fixed. Thanks for reviewing!

EWS

Comment 6 2020-12-11 03:40:19 PST

Committed r270674: <https://trac.webkit.org/changeset/270674> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415983 [details].

Wenson Hsieh

Comment 7 2020-12-12 12:50:04 PST

Reverted r270674 for reason: Broke web content rendering on iOS Committed r270739: <https://trac.webkit.org/changeset/270739>

Per Arne Vollan

Comment 8 2021-02-17 07:04:03 PST

Created attachment 420640 [details] Patch

Brent Fulgham

Comment 9 2021-02-17 09:38:31 PST

Comment on attachment 420640 [details] Patch r=me. We should remember to have a final clean-up radar to remove the dynamic extensions when the GPU Process is fully active and always on.

Per Arne Vollan

Comment 10 2021-02-17 15:06:40 PST

Comment on attachment 420640 [details] Patch Thanks for reviewing!

EWS

Comment 11 2021-02-17 15:14:45 PST

Committed r273036: <https://commits.webkit.org/r273036> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420640 [details].

Note You need to log in before you can comment on or make changes to this bug.