Bug 219730

Summary: [macOS] The development WebContent XPC service is missing a required entitlement
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: REOPENED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219793    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2020-12-09 23:36:46 PST
The message filtering entitlement is missing in com.apple.WebKit.WebContent.Development.xpc on macOS.
Attachments
Patch (1.85 KB, patch)
2020-12-09 23:47 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-12-09 23:45:27 PST
<rdar://problem/72145560>
Per Arne Vollan
Comment 2 2020-12-09 23:47:59 PST
Created attachment 415840 [details] Patch
Brent Fulgham
Comment 3 2020-12-10 11:02:43 PST
Comment on attachment 415840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415840&action=review r=me > Source/WebKit/Scripts/process-entitlements.sh:28 > plistbuddy Add :com.apple.pac.shared_region_id string WebContent It seems like we should enable this for Dev builds, too.
Brent Fulgham
Comment 4 2020-12-10 13:59:04 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 415840 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415840&action=review > > r=me > > > Source/WebKit/Scripts/process-entitlements.sh:28 > > plistbuddy Add :com.apple.pac.shared_region_id string WebContent > > It seems like we should enable this for Dev builds, too. But lets do that as a separate bug after confirming with JSC/Security teams. I don't want to introduce a regression by enabling it without confirming.
EWS
Comment 5 2020-12-10 14:02:19 PST
Committed r270654: <https://trac.webkit.org/changeset/270654> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415840 [details].
Per Arne Vollan
Comment 6 2020-12-11 00:28:25 PST
(In reply to Brent Fulgham from comment #4) > (In reply to Brent Fulgham from comment #3) > > Comment on attachment 415840 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=415840&action=review > > > > r=me > > > > > Source/WebKit/Scripts/process-entitlements.sh:28 > > > plistbuddy Add :com.apple.pac.shared_region_id string WebContent > > > > It seems like we should enable this for Dev builds, too. > > But lets do that as a separate bug after confirming with JSC/Security teams. > I don't want to introduce a regression by enabling it without confirming. Sounds good, thanks for reviewing!
WebKit Commit Bot
Comment 7 2020-12-11 10:59:23 PST
Re-opened since this is blocked by bug 219793
Note You need to log in before you can comment on or make changes to this bug.