Bug 219661

Summary: Add runtime flag for ANGLE on Metal
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, kbr, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
sam: review+
EWS test
ews-feeder: commit-queue-
EWS test 2 none

Dean Jackson
Reported 2020-12-08 17:20:28 PST
Add runtime flag for ANGLE on Metal
Attachments
Patch (6.01 KB, patch)
2020-12-08 17:24 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (9.02 KB, patch)
2020-12-09 15:04 PST, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
EWS test (8.95 KB, patch)
2020-12-10 09:22 PST, Dean Jackson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
EWS test 2 (9.01 KB, patch)
2020-12-10 09:36 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2020-12-08 17:21:12 PST
<rdar://problem/69061894>
Dean Jackson
Comment 2 2020-12-08 17:24:21 PST
Created attachment 415694 [details] Patch
Sam Weinig
Comment 3 2020-12-09 08:37:08 PST
Comment on attachment 415694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415694&action=review > Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:99 > + if (RuntimeEnabledFeatures::sharedFeatures().webGLUsingMetal()) { This is a layering violation. Code in platform/ is not allowed to use RuntimeEnabledFeatures as it is not a platform concept. Instead, the check should be done by the WebCore code that creates this object, and it should pass down this state.
Dean Jackson
Comment 4 2020-12-09 15:04:05 PST
Created attachment 415800 [details] Patch
Sam Weinig
Comment 5 2020-12-09 15:06:53 PST
Comment on attachment 415800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415800&action=review > Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h:56 > +#if PLATFORM(COCOA) Might be slightly nicer to wrap these in HAVE(METAL) rather than PLATFORM(COCOA), but I am not sure that exists yet.
Sam Weinig
Comment 6 2020-12-09 15:08:25 PST
Comment on attachment 415800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415800&action=review > Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:105 > + display = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, reinterpret_cast<void *>(EGL_DEFAULT_DISPLAY), displayAttributes.data()); Existing, but this should be reinterpret_cast<void*> (no space after void.)
Dean Jackson
Comment 7 2020-12-10 09:22:42 PST
Created attachment 415884 [details] EWS test
Dean Jackson
Comment 8 2020-12-10 09:36:08 PST
Created attachment 415887 [details] EWS test 2
Dean Jackson
Comment 9 2020-12-10 10:58:37 PST
Committed r270636: <https://trac.webkit.org/changeset/270636>
Note You need to log in before you can comment on or make changes to this bug.