Bug 219648

Summary: [CMake] Determine when to use $<TARGET_OBJECTS> for executables
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch
mcatanzaro: review+, ews-feeder: commit-queue-
Patch none

Don Olmstead
Reported 2020-12-08 11:29:41 PST
...
Attachments
WIP Patch (9.35 KB, patch)
2020-12-08 11:30 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (12.84 KB, patch)
2020-12-08 12:15 PST, Don Olmstead 		mcatanzaro: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.74 KB, patch)
2020-12-10 12:40 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-12-08 11:30:41 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-12-08 12:15:27 PST
Created attachment 415660 [details] Patch
Michael Catanzaro
Comment 3 2020-12-09 07:20:40 PST
Comment on attachment 415660 [details] Patch Did this break Windows EWS?
Don Olmstead
Comment 4 2020-12-10 12:40:13 PST
Created attachment 415912 [details] Patch
Don Olmstead
Comment 5 2020-12-10 12:47:11 PST
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 415660 [details] > Patch > > Did this break Windows EWS? Seems more like a glitch since this only has effect on executables and DumpRenderTree was not migrated to use the _FRAMEWORKS.
Don Olmstead
Comment 6 2020-12-10 12:57:43 PST
Comment on attachment 415912 [details] Patch The Win EWS is super behind so I'll just watch the bots and roll out if necessary.
EWS
Comment 7 2020-12-10 13:28:43 PST
Committed r270652: <https://trac.webkit.org/changeset/270652> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415912 [details].
Note You need to log in before you can comment on or make changes to this bug.