Bug 219592

Summary: [macOS] Create sandbox extension to HI service when UniversalAccess zoom is enabled
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: NEW ---    
Severity: Normal CC: bfulgham, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pvollan: review?

Description Per Arne Vollan 2020-12-07 02:04:46 PST 
When UniversalAccess zoom is enabled on macOS, access to the service 'com.apple.hiservices-xpcservice' is needed in the WebContent process, and a sandbox extension should be created.
Comment 1 Per Arne Vollan 2020-12-07 02:09:25 PST 
Created attachment 415540 [details]
Patch
Comment 2 Per Arne Vollan 2020-12-07 04:05:54 PST 
Created attachment 415549 [details]
Patch
Comment 3 Per Arne Vollan 2020-12-07 07:50:04 PST 
Created attachment 415555 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2020-12-07 07:50:55 PST 
<rdar://problem/72047078>
Comment 5 Sam Weinig 2020-12-07 08:44:30 PST 
Comment on attachment 415555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415555&action=review

> Source/WebKit/ChangeLog:9
> +        When UniversalAccess zoom is enabled on macOS, access to the service 'com.apple.hiservices-xpcservice' is needed in the WebContent process,
> +        and a sandbox extension should be created.

What in the WebContent process requires this? Is it something that could be proxied to the UIProcess instead?
Comment 6 Per Arne Vollan 2020-12-08 03:48:21 PST 
(In reply to Sam Weinig from comment #5)
> Comment on attachment 415555 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415555&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        When UniversalAccess zoom is enabled on macOS, access to the service 'com.apple.hiservices-xpcservice' is needed in the WebContent process,
> > +        and a sandbox extension should be created.
> 
> What in the WebContent process requires this? Is it something that could be
> proxied to the UIProcess instead?

That is a good point. This is required when calling UAZoomChangeFocus in FrameSelection::notifyAccessibilityForSelectionChange. I have uploaded a patch where this is proxied to the UI process in https://bugs.webkit.org/show_bug.cgi?id=219635.

Thanks for reviewing!