Bug 219572

Summary:

[WebCore] Fix build without PATH_MAX

Product:

WebKit

Reporter:

Samuel Thibault <samuel.thibault>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

darin, don.olmstead, fpizlo, fujii.hironori, keith_miller, mark.lam, smoley, webkit-bug-importer, youennf, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none
Patch	none
Patch	fujii.hironori: review-

Samuel Thibault

Reported 2020-12-05 15:49:29 PST

Created attachment 415505 [details] proposed fix This fixes build on GNU/Hurd, which does not have a PATH_MAX limitation.

Attachments
proposed fix (1.64 KB, patch) 2020-12-05 15:49 PST, Samuel Thibault	no flags	Details Formatted Diff Diff
Patch (2.02 KB, patch) 2020-12-06 12:59 PST, Samuel Thibault	no flags	Details Formatted Diff Diff
Patch (1.88 KB, patch) 2020-12-08 12:39 PST, Samuel Thibault	fujii.hironori: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Samuel Thibault

Comment 1 2020-12-06 12:59:00 PST

Created attachment 415526 [details] Patch

Don Olmstead

Comment 2 2020-12-07 08:25:03 PST

I feel like it'd be safer to do a check in the CMake code for realpath which would create a HAVE_REALPATH variable. See Source/cmake/OptionsCommon.cmake for the other HAVE checks.

Radar WebKit Bug Importer

Comment 3 2020-12-07 13:51:30 PST

<rdar://problem/72062538>

Fujii Hironori

Comment 4 2020-12-07 18:02:41 PST

(In reply to Don Olmstead from comment #2) > I feel like it'd be safer to do a check in the CMake code for realpath which > would create a HAVE_REALPATH variable. I think adding HAVE_REALPATH can't solve this problem. I don't know which Unix WebKit is supporting, but Linux and FreeBSD can take NULL as the second argument of realpath, as far as I read the documents. I think it's better to remove the old code.

Yusuke Suzuki

Comment 5 2020-12-08 12:29:56 PST

Comment on attachment 415526 [details] Patch Setting r- based on Hironori's comment. Could you update the patch :D ?

Samuel Thibault

Comment 6 2020-12-08 12:39:31 PST

Created attachment 415663 [details] Patch

Samuel Thibault

Comment 7 2020-12-08 12:40:19 PST

I have done so

Darin Adler

Comment 8 2020-12-08 12:41:09 PST

This idiom occurs in other places, not just HyphenationLibHyphen.cpp. I found it in SandboxUtilities.mm, SandboxInitializationParametersCocoa.mm, AuxiliaryProcessMac.mm, FileSystemPOSIX.cpp, and StdFilesystem.cpp. I think it’s peculiar to do this in only one place.

Fujii Hironori

Comment 9 2020-12-22 19:55:39 PST

Comment on attachment 415663 [details] Patch r- for comment#8.

Samuel Thibault

Comment 10 2025-01-12 09:19:00 PST

Apparently this fell in the cracks of my todo-list. I have reworked the patch, submitted to https://github.com/WebKit/WebKit/pull/38913 , along other pull requests that fix building on GNU/Hurd (https://bugs.webkit.org/show_bug.cgi?id=285806)

Note You need to log in before you can comment on or make changes to this bug.