| Summary: | [WebCore] Fix build without PATH_MAX | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Samuel Thibault <samuel.thibault> | ||||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | darin, don.olmstead, fpizlo, Hironori.Fujii, keith_miller, mark.lam, smoley, webkit-bug-importer, youennf, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 415526 [details]
Patch
I feel like it'd be safer to do a check in the CMake code for realpath which would create a HAVE_REALPATH variable. See Source/cmake/OptionsCommon.cmake for the other HAVE checks. (In reply to Don Olmstead from comment #2) > I feel like it'd be safer to do a check in the CMake code for realpath which > would create a HAVE_REALPATH variable. I think adding HAVE_REALPATH can't solve this problem. I don't know which Unix WebKit is supporting, but Linux and FreeBSD can take NULL as the second argument of realpath, as far as I read the documents. I think it's better to remove the old code. Comment on attachment 415526 [details]
Patch
Setting r- based on Hironori's comment. Could you update the patch :D ?
Created attachment 415663 [details]
Patch
I have done so This idiom occurs in other places, not just HyphenationLibHyphen.cpp. I found it in SandboxUtilities.mm, SandboxInitializationParametersCocoa.mm, AuxiliaryProcessMac.mm, FileSystemPOSIX.cpp, and StdFilesystem.cpp. I think it’s peculiar to do this in only one place. Comment on attachment 415663 [details] Patch r- for comment#8. |
Created attachment 415505 [details] proposed fix This fixes build on GNU/Hurd, which does not have a PATH_MAX limitation.