Summary: | REGRESSION(r270458): Crash loading https://browserbench.org/JetStream/ | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari Technology Preview | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=219007 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2020-12-05 12:40:22 PST
Created attachment 415500 [details]
Patch
Created attachment 415501 [details]
Patch
This is caused by r270458 where the backendSize is calculated from the backend data (IOSurface if it is accelerated CG backend). I reviewed all the places which call sinkIntoNativeImage() and I found only two places which call backendSize after sinking the backend into a NativeImage. These places are: ImageBufferIOSurfaceBackend::drawConsuming() ImageBufferCGBackend::sinkIntoImage() The one in ImageBufferCGBackend::sinkIntoImage() is already fixed the same way in r270458 because it was caught by the layout tests. Committed r270479: <https://trac.webkit.org/changeset/270479> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415501 [details]. |