Bug 219524

Summary: [iOS] Provide a context menu action to perform accessibility image extraction
Product: WebKit Reporter: Devin Rousso <hi>
Component: PlatformAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219398
https://bugs.webkit.org/show_bug.cgi?id=221058
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2020-12-03 18:53:56 PST
<rdar://problem/69969613>
Attachments
Patch (8.67 KB, patch)
2020-12-03 19:02 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2020-12-04 10:24 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-12-03 19:02:11 PST
Created attachment 415375 [details] Patch
Wenson Hsieh
Comment 2 2020-12-04 08:05:25 PST
Comment on attachment 415375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415375&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:76 > +- (void)actionSheetAssistant:(WKActionSheetAssistant *)assistant imageExtraction:(UIImage *)image; Nit - this is a bit of a funny name for a delegate method. Usually, it's either a noun (if the delegate returns something), like `- (Foo *)instance:fooForPurpose:`, or it's a verb, like `- (void)instance:doFoo:`. Maybe this should be something along the lines of `-actionSheetAssistant:extractImage:` or `-actionSheetAssistant:handleImageExtraction:`.
Devin Rousso
Comment 3 2020-12-04 10:24:57 PST
Created attachment 415426 [details] Patch
EWS
Comment 4 2020-12-04 10:57:14 PST
Committed r270436: <https://trac.webkit.org/changeset/270436> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415426 [details].
Note You need to log in before you can comment on or make changes to this bug.