Bug 219521

Summary: [GPUP] Move MediaCapabilities into the GPU process
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
eric.carlson: review+
Patch for landing none

Description Jer Noble 2020-12-03 18:12:46 PST 
[GPUP] Move MediaCapabilities into the GPU process
Comment 1 Jer Noble 2020-12-03 19:07:28 PST 
Created attachment 415376 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-12-03 19:07:29 PST 
<rdar://problem/71963056>
Comment 3 Jer Noble 2020-12-03 21:43:05 PST 
Created attachment 415385 [details]
Patch
Comment 4 Jer Noble 2020-12-03 22:14:48 PST 
Created attachment 415388 [details]
Patch
Comment 5 Jer Noble 2020-12-03 23:01:29 PST 
Created attachment 415390 [details]
Patch
Comment 6 Jer Noble 2020-12-04 09:15:57 PST 
Created attachment 415420 [details]
Patch
Comment 7 Jer Noble 2020-12-04 09:36:26 PST 
Created attachment 415423 [details]
Patch
Comment 8 Eric Carlson 2020-12-04 11:17:36 PST 
Comment on attachment 415423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415423&action=review

> Source/WebCore/platform/MediaCapabilitiesDecodingInfo.h:65
> +    Optional<MediaCapabilitiesInfo> info = MediaCapabilitiesInfo::decode(decoder);

Nit: `auto`

> Source/WebCore/platform/MediaCapabilitiesEncodingInfo.h:65
> +    Optional<MediaCapabilitiesInfo> info = MediaCapabilitiesInfo::decode(decoder);

Ditto

> Source/WebCore/platform/mediacapabilities/MediaDecodingConfiguration.h:50
> +    Optional<MediaConfiguration> mediaConfiguration = MediaConfiguration::decode(decoder);

Ditto.

> Source/WebCore/platform/mediacapabilities/MediaEncodingConfiguration.h:50
> +    Optional<MediaConfiguration> mediaConfiguration = MediaConfiguration::decode(decoder);

Ditto.

> Source/WebCore/platform/mediacapabilities/VideoConfiguration.h:113
> +
> +

Nit: extra line
Comment 9 Jer Noble 2020-12-04 12:34:49 PST 
Created attachment 415446 [details]
Patch for landing
Comment 10 EWS 2020-12-04 14:58:14 PST 
Committed r270462: <https://trac.webkit.org/changeset/270462>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415446 [details].