Summary: | IPC should support non-byte aligned data references | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||||
Component: | WebKit2 | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, cdumez, eric.carlson, ews-watchlist, glenn, hi, jer.noble, jiewen_tan, joepeck, peng.liu6, philipj, rniwa, sam, sergio, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 217211, 217216 | ||||||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2020-12-03 03:49:41 PST
Created attachment 415293 [details]
Patch
Created attachment 415294 [details]
Patch
Comment on attachment 415294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415294&action=review > Source/WebKit/Platform/IPC/ArrayReference.h:76 > + size_t m_size { }; const T* m_data { nullptr }; size_t m_size { 0 }; > Source/WebKit/Platform/IPC/ArrayReference.h:117 > + const T* m_data { }; const T* m_data { nullptr }; Comment on attachment 415294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415294&action=review r=me with nits. > Source/WebKit/ChangeLog:10 > + size is determined run-time. *at* run-time > Source/WebKit/ChangeLog:17 > + DataReference or ArrayReference, as a synchronized call return value. synchronized -> synchronous IPC > Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:33 > + I don't think we usually use a blank line in such cases. > Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:34 > + ditto. > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:34 > + ditto. > Source/WebKit/Platform/IPC/ArrayReference.h:2 > + * Copyright (C) 2010 Apple Inc. All rights reserved. 2010-2020 >> Source/WebKit/Platform/IPC/ArrayReference.h:76 >> + size_t m_size { }; > > const T* m_data { nullptr }; > size_t m_size { 0 }; Agreed. >> Source/WebKit/Platform/IPC/ArrayReference.h:117 >> + const T* m_data { }; > > const T* m_data { nullptr }; Agreed. > Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:43 > + WebCore::Page* page = inspectorFrontend.frontendPage(); auto* Created attachment 415717 [details]
Patch
Created attachment 415718 [details]
Patch
Committed r270573: <https://trac.webkit.org/changeset/270573> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415718 [details]. This patch broke iOS builds (Apple internal builds). (In reply to Ryosuke Niwa from comment #9) > This patch broke iOS builds (Apple internal builds). Fixed in http://trac.webkit.org/r270576 Thanks, sorry! |