Bug 219487 – IPC should support non-byte aligned data references

• Component: WebKit2
• Status: RESOLVED FIXED

[Kimmo Kinnunen]

IPC should support non-byte aligned data references

This is needed to efficiently pass arrays of floats and ints in the WebGL GPU Process implementation

[Kimmo Kinnunen]

Created attachment 415293 [details]
Patch

[Kimmo Kinnunen]

Created attachment 415294 [details]
Patch

[Peng Liu]

Comment on attachment 415294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415294&action=review

> Source/WebKit/Platform/IPC/ArrayReference.h:76
> +    size_t m_size { };

const T* m_data { nullptr };
size_t m_size { 0 };

> Source/WebKit/Platform/IPC/ArrayReference.h:117
> +    const T* m_data { };

const T* m_data { nullptr };

[Chris Dumez]

Comment on attachment 415294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415294&action=review

r=me with nits.

> Source/WebKit/ChangeLog:10
> +        size is determined run-time.

*at* run-time

> Source/WebKit/ChangeLog:17
> +        DataReference or ArrayReference, as a synchronized call return value.

synchronized -> synchronous IPC

> Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:33
> +

I don't think we usually use a blank line in such cases.

> Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:34
> +

ditto.

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:34
> +

ditto.

> Source/WebKit/Platform/IPC/ArrayReference.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

2010-2020

>> Source/WebKit/Platform/IPC/ArrayReference.h:76
>> +    size_t m_size { };
> 
> const T* m_data { nullptr };
> size_t m_size { 0 };

Agreed.

>> Source/WebKit/Platform/IPC/ArrayReference.h:117
>> +    const T* m_data { };
> 
> const T* m_data { nullptr };

Agreed.

> Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:43
> +    WebCore::Page* page = inspectorFrontend.frontendPage();

auto*

[Kimmo Kinnunen]

Created attachment 415717 [details]
Patch

[Kimmo Kinnunen]

Created attachment 415718 [details]
Patch

[EWS]

Committed r270573: <https://trac.webkit.org/changeset/270573>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415718 [details].

[Radar WebKit Bug Importer]

<rdar://problem/72126664>

[Ryosuke Niwa]

This patch broke iOS builds (Apple internal builds).

[Ryosuke Niwa]

(In reply to Ryosuke Niwa from comment #9)
> This patch broke iOS builds (Apple internal builds).

Fixed in http://trac.webkit.org/r270576

[Kimmo Kinnunen]

Thanks, sorry!