Summary: | Change two layout tests to work with Chrome's 'file' url policy. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Feng Qian <feng> | ||||||||
Component: | Tools / Tests | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, ap | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Feng Qian
2008-10-29 11:10:09 PDT
Created attachment 24749 [details]
changes in the test
Comment on attachment 24749 [details]
changes in the test
r=me
I presume the test now works in Firefox, too?
The test is failing in FF for different reasons. Before the change, the test failed because it throws an exception: NS_ERROR_ILLEGAL_VALUE, ex.code is undefined. After the change, the test failed because no exception is thrown. (In reply to comment #2) > (From update of attachment 24749 [details] [edit]) > r=me > > I presume the test now works in Firefox, too? > Created attachment 24755 [details]
patch for another test
Another test has a similar issue. It sends XHR request to 'about:blank'. It is allowed in Safari if the source URL is a file URL. Chrome does not allow it.
The test is testing something else, so make it send URL to itself.
Comment on attachment 24755 [details]
patch for another test
r=me
You may need to make these patches easier to land (correct bug title, add ChangeLogs, possibly merge patches into one) - or to find a committer who is willing to do this for you.
Created attachment 24762 [details]
a merge patch with changelog
This is a merged patch with changelog, it is easier for commit.
Comment on attachment 24762 [details]
a merge patch with changelog
r=me
Will land. LayoutTests/ChangeLog: locally modified LayoutTests/fast/dom/null-document-xmlhttprequest-open.html: locally modified LayoutTests/fast/dom/xmlhttprequest-invalid-values.html: locally modified M LayoutTests/ChangeLog M LayoutTests/fast/dom/null-document-xmlhttprequest-open.html M LayoutTests/fast/dom/xmlhttprequest-invalid-values.html Committed r39365 M LayoutTests/ChangeLog M LayoutTests/fast/dom/xmlhttprequest-invalid-values.html M LayoutTests/fast/dom/null-document-xmlhttprequest-open.html r39365 = d0786620de79c0565e62411bd46561ebdb5df15a (trunk) |