Bug 219431

Summary: GPU Process WindowServer blocking prevents CGL
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217211, 217216    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kimmo Kinnunen
Reported 2020-12-02 07:17:54 PST
GPU Process WindowServer blocking prevents CGL Currently block is done with setApplicationIsDaemon I managed to use the Web Process method of blocking WindowServer on iMac Pro I failed to use the method on MacBook with Intel/AMD
Attachments
Patch (1.96 KB, patch)
2020-12-03 06:00 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2020-12-04 04:17 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2020-12-04 04:22 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-02 07:18:03 PST
<rdar://problem/71893390>
Kimmo Kinnunen
Comment 2 2020-12-03 06:00:44 PST
Created attachment 415299 [details] Patch
Darin Adler
Comment 3 2020-12-03 10:59:00 PST
Comment on attachment 415299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415299&action=review > Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:48 > + auto retval = CGSSetDenyWindowServerConnections(true); Not really WebKit style to use the name "retval" and I would prefer "result", "returnValue", or "errorCode", or even "error".
Kimmo Kinnunen
Comment 4 2020-12-04 04:17:59 PST
Created attachment 415406 [details] Patch
Kimmo Kinnunen
Comment 5 2020-12-04 04:20:47 PST
Thanks for the review. Per Arne found a proper fix. The GPU Process property list was missing allowing the automatic graphics switching. It's unknown if this is intended limitation or accidental error in CGL.
Kimmo Kinnunen
Comment 6 2020-12-04 04:22:11 PST
Created attachment 415407 [details] Patch
Per Arne Vollan
Comment 7 2020-12-04 05:02:12 PST
Comment on attachment 415407 [details] Patch R=me. I think the build failures are unrelated.
EWS
Comment 8 2020-12-04 07:44:06 PST
Committed r270430: <https://trac.webkit.org/changeset/270430> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415407 [details].
Note You need to log in before you can comment on or make changes to this bug.