Bug 219416

Summary: Simplify some callsites of WheelEventTestMonitor
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Simon Fraser (smfr)
Reported 2020-12-01 17:09:09 PST
Simplify some callsites of WheelEventTestMonitor
Attachments
Patch (22.50 KB, patch)
2020-12-01 17:12 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (22.33 KB, patch)
2020-12-01 18:46 PST, Simon Fraser (smfr) 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-12-01 17:12:31 PST
Created attachment 415179 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-12-01 18:46:45 PST
Created attachment 415186 [details] Patch
Daniel Bates
Comment 3 2020-12-01 19:00:04 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=415179&action=review > Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:161 > + auto makeDeferrer = [&]() -> WheelEventTestMonitorCompletionDeferrer { Consider just using a local and moving it because this function is unconditionally invoked (so not avoiding computing it sometimes) and its body is branchless. Oh, the repeated reinterpret_casts i now see. Could extract this lambda into a real function that does the cast. > Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:101 > + auto makeDeferrer = [&]() -> WheelEventTestMonitorCompletionDeferrer { Same as above.
Simon Fraser (smfr)
Comment 4 2020-12-01 19:28:44 PST
https://trac.webkit.org/r270338
Radar WebKit Bug Importer
Comment 5 2020-12-01 19:29:20 PST
<rdar://problem/71878326>
Note You need to log in before you can comment on or make changes to this bug.