Bug 219384

Summary: [WK1] Only the first wheel event in a gesture should be cancelable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218764    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch cdumez: review+, ews-feeder: commit-queue-

Simon Fraser (smfr)
Reported 2020-11-30 21:14:40 PST
[WK1] Only the first wheel event in a gesture should be cancelable
Attachments
Patch (17.34 KB, patch)
2020-11-30 21:18 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.31 KB, patch)
2020-11-30 21:28 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (17.32 KB, patch)
2020-11-30 22:55 PST, Simon Fraser (smfr) 		cdumez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-11-30 21:18:50 PST
Created attachment 415095 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-11-30 21:19:21 PST
<rdar://problem/71836485>
Simon Fraser (smfr)
Comment 3 2020-11-30 21:28:35 PST
Created attachment 415096 [details] Patch
Simon Fraser (smfr)
Comment 4 2020-11-30 22:55:10 PST
Created attachment 415100 [details] Patch
Chris Dumez
Comment 5 2020-12-01 09:52:09 PST
Comment on attachment 415100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415100&action=review > LayoutTests/fast/events/wheel/first-wheel-event-cancelable.html:44 > + debug('Tests preventDefault on the first event results in the rest of the events being cancelable') description() would likely look better than debug(). > LayoutTests/fast/events/wheel/wheel-events-become-non-cancelable.html:55 > + debug('Tests that events in the gesture are non-cancelable if preventDefault was not called on the first event'); ditto.
Simon Fraser (smfr)
Comment 6 2020-12-01 10:02:17 PST
https://trac.webkit.org/r270312
Note You need to log in before you can comment on or make changes to this bug.