Bug 219355
| Summary: | [GStreamer] SleepDisabler leaked when closing tab | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, pnormand |
| Priority: | P2 | Keywords: | DoNotImportToRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=186971 https://bugs.webkit.org/show_bug.cgi?id=219354 https://bugs.webkit.org/show_bug.cgi?id=219353 |
||
Michael Catanzaro
Add some WTFLogAlways() debug to the SleepDisabler constructor and destructor to see when it is created and destroyed. Start playing a YouTube video and note that a SleepDisabler is created. Then close the browser tab. Notice that the destructor never runs: the SleepDisabler has somehow been leaked.
This might be a media bug, or it might be a higher-level bug if some other code is leaking the entire media player (hopefully not?). I'm not sure what is happening.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
I can't reproduce this after fixing bug 219353.
Michael Catanzaro
I can no longer reproduce this, so I'll close this. But see also bug #219354.
Michael Catanzaro
After more testing, I'm fairly confident this is reliably fixed.