Summary: | REGRESSION(r270185) [GTK] Some webgl failures after multivalue setter refactor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||
Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kkinnunen, kondapallykalyan, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=219256 | ||||||
Attachments: |
|
Description
Lauro Moura
2020-11-29 20:17:36 PST
Created attachment 415006 [details]
Patch
Thanks for the investigation. The GTK EWS bots were green when I submitted the patch that regressed. Do you (or anyone) know why is this? My mental model is that "Bots green == All tests passed and will most likely pass in future too for this patch." (In reply to Kimmo Kinnunen from comment #2) > Thanks for the investigation. > Thanks for the quick patch > The GTK EWS bots were green when I submitted the patch that regressed. Do > you (or anyone) know why is this? > > My mental model is that "Bots green == All tests passed and will most likely > pass in future too for this patch." Currently the main EWS queue only runs GTK API tests. We have a GTK Layout tests bot in the UAT queue and we are working to make it stable enough to be moved to the main queue. I've tested the patch locally and indeed it makes all the tests pass. Just need to update the expectations but I can do it unreviewed once this lands. Committed r274410: <https://commits.webkit.org/r274410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415006 [details]. |