Bug 219319

Summary: Remove enums for GCGLenum constants in GraphicsContextGL and ExtensionsGL
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: WebGLAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, mmaxfield, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2020-11-27 12:19:30 PST
When compiling with clang-cl the WinCairo build fails with ..\..\Source\WebCore\html\canvas\WebGLDrawBuffers.cpp(77,29): error: non-constant-expression cannot be narrowed from type 'WebCore::GraphicsContextGL::(anonymous enum at ..\..\Source\WebCore\platform\graphics\GraphicsContextGL.h:64:5)' to 'GCGLenum' (aka 'unsigned int') in initializer list [-Wc++11-narrowing] GCGLenum value[1] { (bufs[0] == GraphicsContextGL::BACK) ? GraphicsContextGL::COLOR_ATTACHMENT0 : GraphicsContextGL::NONE }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ..\..\Source\WebCore\html\canvas\WebGLDrawBuffers.cpp(77,29): note: insert an explicit cast to silence this issue GCGLenum value[1] { (bufs[0] == GraphicsContextGL::BACK) ? GraphicsContextGL::COLOR_ATTACHMENT0 : GraphicsContextGL::NONE }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<GCGLenum>( )
Attachments
Patch (74.73 KB, patch)
2020-11-27 13:02 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-11-27 13:02:16 PST
Created attachment 414968 [details] Patch
EWS
Comment 2 2020-11-28 06:41:18 PST
Committed r270218: <https://trac.webkit.org/changeset/270218> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414968 [details].
Radar WebKit Bug Importer
Comment 3 2020-11-28 06:42:18 PST
<rdar://problem/71774248>
Note You need to log in before you can comment on or make changes to this bug.