Summary: | [Flatpak SDK] Add clangd | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, vjaquez, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2020-11-27 02:40:15 PST
Created attachment 414930 [details]
Patch
Comment on attachment 414930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414930&action=review > Tools/buildstream/project.conf:47 > + github_files: https://github.com/ Yet here both are using “https://github.com/” 🤔️ Does this mean that something is missing to make “github_files” point to a different host? (In reply to Adrian Perez from comment #2) > Comment on attachment 414930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414930&action=review > > > Tools/buildstream/project.conf:47 > > + github_files: https://github.com/ > > Yet here both are using “https://github.com/” 🤔️ > > Does this mean that something is missing to make “github_files” point to > a different host? I did just like in the FDO SDK. Their cache server requires a different alias for "static" files vs git repositories, IIUC. (In reply to Philippe Normand from comment #4) > https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/master/include/ > _private/aliases.yml#L36 I did some digging, too… I've read from the Buildstream documentation that this would allow users to set a different mirror server in their local configuration for static files which are not repository fetches: https://docs.buildstream.build/1.6.1/format_project.html#project-essentials-mirrors All right, then! Tools/Scripts/svn-apply failed to apply attachment 414930 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Committed r270193: <https://trac.webkit.org/changeset/270193> |