Bug 219302

Summary: [Flatpak SDK] Add clangd
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aperez: review+, ews-feeder: commit-queue-

Philippe Normand
Reported 2020-11-27 02:40:15 PST
.
Attachments
Patch (2.61 KB, patch)
2020-11-27 02:43 PST, Philippe Normand 		aperez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-11-27 02:43:48 PST
Created attachment 414930 [details] Patch
Adrian Perez
Comment 2 2020-11-27 04:02:46 PST
Comment on attachment 414930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414930&action=review > Tools/buildstream/project.conf:47 > + github_files: https://github.com/ Yet here both are using “https://github.com/” 🤔️ Does this mean that something is missing to make “github_files” point to a different host?
Philippe Normand
Comment 3 2020-11-27 04:13:48 PST
(In reply to Adrian Perez from comment #2) > Comment on attachment 414930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414930&action=review > > > Tools/buildstream/project.conf:47 > > + github_files: https://github.com/ > > Yet here both are using “https://github.com/” 🤔️ > > Does this mean that something is missing to make “github_files” point to > a different host? I did just like in the FDO SDK. Their cache server requires a different alias for "static" files vs git repositories, IIUC.
Adrian Perez
Comment 5 2020-11-27 04:24:31 PST
(In reply to Philippe Normand from comment #4) > https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/master/include/ > _private/aliases.yml#L36 I did some digging, too… I've read from the Buildstream documentation that this would allow users to set a different mirror server in their local configuration for static files which are not repository fetches: https://docs.buildstream.build/1.6.1/format_project.html#project-essentials-mirrors All right, then!
EWS
Comment 6 2020-11-27 04:41:52 PST
Tools/Scripts/svn-apply failed to apply attachment 414930 [details] to trunk. Please resolve the conflicts and upload a new patch.
Philippe Normand
Comment 7 2020-11-27 06:49:02 PST
Committed r270193: <https://trac.webkit.org/changeset/270193>
Radar WebKit Bug Importer
Comment 8 2020-11-27 06:49:16 PST
<rdar://problem/71764528>
Note You need to log in before you can comment on or make changes to this bug.