| Summary: | [WebIDL] Remove [CustomToStringName] and Location-specific extended attributes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
| Component: | Bindings | Assignee: | Alexey Shvayka <ashvayka> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Minor | CC: | 077janesmith, cdumez, clopez, darin, esprehn+autocc, ews-watchlist, joepeck, kondapallykalyan, sam, webkit-bug-importer, youennf, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/26765 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Shvayka
2020-11-24 09:26:12 PST
Created attachment 414843 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 414843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414843&action=review Really excited to see more of these old custom extended attributes going away. Great work! > LayoutTests/imported/w3c/ChangeLog:11 > + * web-platform-tests/html/browsers/history/the-location-interface/location-define-own-property-expected.txt: Added. > + * web-platform-tests/html/browsers/history/the-location-interface/location-define-own-property.html: Added. > + * web-platform-tests/html/browsers/history/the-location-interface/location-prototype-define-own-property-expected.txt: Added. > + * web-platform-tests/html/browsers/history/the-location-interface/location-prototype-define-own-property.html: Added. Did you import these using the import-w3c-tests script? (In reply to Sam Weinig from comment #4) > Did you import these using the import-w3c-tests script? No, those tests are authored against the patch; I was hoping to export them. Do you consider the tests too specific for WPT and would rather prefer them in fast/dom? (In reply to Alexey Shvayka from comment #5) > (In reply to Sam Weinig from comment #4) > > Did you import these using the import-w3c-tests script? > > No, those tests are authored against the patch; I was hoping to export them. > Do you consider the tests too specific for WPT and would rather prefer them > in fast/dom? imported directory is specifically for imported tests. So, only -expect.txt files and auto-imported files exist under this directory. Let's add them to http/wpt/ instead :) Created attachment 415465 [details]
Patch
Adjust __defineGetter__ tests.
(In reply to Yusuke Suzuki from comment #6) > imported directory is specifically for imported tests. So, only -expect.txt > files and auto-imported files exist under this directory. > Let's add them to http/wpt/ instead :) I am putting them to LayoutTests/imported to leverage the WPT export process (https://trac.webkit.org/wiki/WPTExportProcess): once the patch is reviewed, I can land a WPT PR (https://github.com/web-platform-tests/wpt/pull/26765) with those tests w/o additional review on GitHub (which saves a lot of time), and only then I would land the patch itself. Committed r271092: <https://trac.webkit.org/changeset/271092> |