Bug 219263

Summary: Failing webkitpy test: svn_unittest.TestRemoteSvn.test_info
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218827
Attachments:
Description Flags
Patch none

Description Aakash Jain 2020-11-23 13:11:48 PST
Following unit-test added in r270038 is failing in non-PST timezones. It pass when I manually change the timezone to PST in my system preferences.

[1404/1959] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_info failed:                                                                                   
  Traceback (most recent call last):
    File "OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 255, in test_info
      }, remote.Svn(self.remote).info())
  AssertionError: {'Last Changed Date': '2020-10-02 11:58:20', 'Last Changed Rev': '6', 'Last Chan [truncated]... != {'Last Changed Date': u'2020-10-02 14:58:20', 'Last Changed Rev': u'6', 'Last Ch [truncated]...
  - {'Last Changed Author': 'jbedard@apple.com',
  + {'Last Changed Author': u'jbedard@apple.com',
  ?                         +
  
  -  'Last Changed Date': '2020-10-02 11:58:20',
  ?                                    ^
  
  +  'Last Changed Date': u'2020-10-02 14:58:20',
  ?                       +             ^
  
  -  'Last Changed Rev': '6',
  +  'Last Changed Rev': u'6',
  ?                      +
  
     'Revision': 10}
  
Ran 1959 tests in 6.833s                                                                                                                   
FAILED (failures=1, errors=0)
Comment 1 Aakash Jain 2020-11-23 13:12:56 PST
This issue might be similar to https://bugs.webkit.org/show_bug.cgi?id=218079
Comment 2 Radar WebKit Bug Importer 2020-11-30 08:28:56 PST
<rdar://problem/71806358>
Comment 3 Jonathan Bedard 2020-11-30 08:33:14 PST
Created attachment 415025 [details]
Patch
Comment 4 EWS 2020-11-30 09:07:58 PST
Committed r270247: <https://trac.webkit.org/changeset/270247>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415025 [details].