Bug 219260

Summary: Fix ANGLE CMakeLists.txt warnings
Product: WebKit Reporter: Rob Buis <rbuis>
Component: ANGLEAssignee: Rob Buis <rbuis>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: annulen, dino, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, pnormand, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 244008    
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-11-23 09:20:49 PST
Make Warning (dev) at Source/ThirdParty/ANGLE/CMakeLists.txt:103: Syntax Warning in cmake code at column 37 Argument not separated from preceding token by whitespace. This warning is for project developers. Use -Wno-dev to suppress it.
Attachments
Patch (1.46 KB, patch)
2020-11-23 09:23 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-11-23 09:23:03 PST
Created attachment 414806 [details] Patch
EWS Watchlist
Comment 2 2020-11-25 19:16:44 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
EWS
Comment 3 2020-11-27 08:32:18 PST
Committed r270194: <https://trac.webkit.org/changeset/270194> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414806 [details].
Radar WebKit Bug Importer
Comment 4 2020-11-27 08:33:22 PST
<rdar://problem/71765587>
Ryan Haddad
Comment 5 2020-11-30 15:43:48 PST
Reverted r270129, r270194, and r270258 for reason: r270129 broke macCatalyst build Committed r270272: <https://trac.webkit.org/changeset/270272>
Rob Buis
Comment 6 2020-12-01 03:27:41 PST
Since the revert of r270129 this is no longer needed.
Note You need to log in before you can comment on or make changes to this bug.