Summary: | AudioWorkletProcessor::process() may get called on non-audio worklet thread and crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2020-11-20 09:43:36 PST
Created attachment 414692 [details]
Patch
Comment on attachment 414692 [details]
Patch
r=me
Does this mean we can remove the thread check before we take the JS lock?
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 414692 [details] > Patch > > r=me > > Does this mean we can remove the thread check before we take the JS lock? I will double check but I do not believe so. Until the worklet is ready, handlePreRenderTask() and process() will get called on a non-worklet thread. Committed r270127: <https://trac.webkit.org/changeset/270127> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414692 [details]. |