| Summary: | Remove DataDetectorType::None, it's not appropriate for a enum used as an OptionSet | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | andersca, ews-watchlist, mifenton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2020-11-20 09:15:08 PST
Created attachment 414689 [details]
Patch
Comment on attachment 414689 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414689&action=review > Source/WebCore/page/Settings.yaml:97 > + default: static_cast<DataDetectorType>(0) Not sure how this is turned into C++ but I wonder if it's possible to make it be { } ? (In reply to Anders Carlsson from comment #2) > Comment on attachment 414689 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414689&action=review > > > Source/WebCore/page/Settings.yaml:97 > > + default: static_cast<DataDetectorType>(0) > > Not sure how this is turned into C++ but I wonder if it's possible to make > it be { } ? Hm, not sure. Will experiment with that. Well, oops, looks like this breaks Debug tests due to an assert in OptionSet (which makes sense). Maybe { } will fair better.
Created attachment 414696 [details]
Patch
|